Skip to content

Commit

Permalink
test: rename $satisfied to $satisfied_prereq
Browse files Browse the repository at this point in the history
All other shell variables that are used to globally keep track of
states related to prerequisite have "prereq" somewhere in their
names.  Be consistent and avoid potential name crashes with other
kinds of satisfaction in the future.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Junio C Hamano committed Jul 27, 2012
1 parent cdd159b commit f3cfc3b
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions t/test-lib-functions.sh
Original file line number Diff line number Diff line change
Expand Up @@ -221,9 +221,9 @@ write_script () {
# capital letters by convention).

test_set_prereq () {
satisfied="$satisfied$1 "
satisfied_prereq="$satisfied_prereq$1 "
}
satisfied=" "
satisfied_prereq=" "

test_have_prereq () {
# prerequisites can be concatenated with ','
Expand All @@ -239,7 +239,7 @@ test_have_prereq () {
for prerequisite
do
total_prereq=$(($total_prereq + 1))
case $satisfied in
case "$satisfied_prereq" in
*" $prerequisite "*)
ok_prereq=$(($ok_prereq + 1))
;;
Expand Down

0 comments on commit f3cfc3b

Please sign in to comment.