Skip to content

Commit

Permalink
t/README: test_must_fail is for testing Git
Browse files Browse the repository at this point in the history
When a test wants to make sure there is no <string> in an output
file, we should just say "! grep string output".

"test_must_fail" is there only to test Git command and catch unusual
deaths we know about (e.g. segv) as an error, not as an expected
failure.  "test_must_fail grep string output" is unnecessary, as
we are not making sure the system binaries do not dump core or
anything like that.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Junio C Hamano committed Jun 4, 2013
1 parent 4b8f772 commit f445500
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions t/README
Original file line number Diff line number Diff line change
Expand Up @@ -324,6 +324,9 @@ Don't:
use 'test_must_fail git cmd'. This will signal a failure if git
dies in an unexpected way (e.g. segfault).

On the other hand, don't use test_must_fail for running regular
platform commands; just use '! cmd'.

- use perl without spelling it as "$PERL_PATH". This is to help our
friends on Windows where the platform Perl often adds CR before
the end of line, and they bundle Git with a version of Perl that
Expand Down

0 comments on commit f445500

Please sign in to comment.