Skip to content

Commit

Permalink
exec_cmd.c: use find_last_dir_sep() for code simplification
Browse files Browse the repository at this point in the history
We are trying to extract dirname from argv0 in the git_extract_argv0_path().
But in the same time, the <git-compat-util.h> provides find_last_dir_sep()
to get dirname from a given path.  Let's use it instead of loop for the code
simplification.

Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Alexander Kuleshov authored and Junio C Hamano committed Feb 19, 2016
1 parent a2558fb commit f459823
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions exec_cmd.c
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,10 @@ const char *git_extract_argv0_path(const char *argv0)

if (!argv0 || !*argv0)
return NULL;
slash = argv0 + strlen(argv0);

while (argv0 <= slash && !is_dir_sep(*slash))
slash--;
slash = find_last_dir_sep(argv0);

if (slash >= argv0) {
if (slash) {
argv0_path = xstrndup(argv0, slash - argv0);
return slash + 1;
}
Expand Down

0 comments on commit f459823

Please sign in to comment.