Skip to content

Commit

Permalink
rebase -i -p: Fix --continue after a merge could not be redone
Browse files Browse the repository at this point in the history
When a merge that has a conflict was rebased, then rebase stopped to let
the user resolve the conflicts. However, thereafter --continue failed
because the author-script was not saved. (This is rebase -i's way to
preserve a commit's authorship.) This fixes it by doing taking the same
failure route after a merge that is also taken after a normal cherry-pick.

Signed-off-by: Johannes Sixt <j6t@kdbg.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Johannes Sixt authored and Junio C Hamano committed Dec 21, 2008
1 parent 03c4829 commit f5b49ea
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
3 changes: 1 addition & 2 deletions git-rebase--interactive.sh
Original file line number Diff line number Diff line change
Expand Up @@ -256,9 +256,8 @@ pick_one_preserving_merges () {
output git merge $STRATEGY -m "$msg" \
$new_parents
then
git rerere
printf "%s\n" "$msg" > "$GIT_DIR"/MERGE_MSG
die Error redoing merge $sha1
die_with_patch $sha1 "Error redoing merge $sha1"
fi
;;
*)
Expand Down
2 changes: 1 addition & 1 deletion t/t3409-rebase-preserve-merges.sh
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ test_expect_success 'rebase -p fakes interactive rebase' '
)
'

test_expect_failure '--continue works after a conflict' '
test_expect_success '--continue works after a conflict' '
(
cd clone2 &&
git fetch &&
Expand Down

0 comments on commit f5b49ea

Please sign in to comment.