Skip to content

Commit

Permalink
tests: make test_expect_code quieter on success
Browse files Browse the repository at this point in the history
A command exiting with the expected status is not particularly
notable.

While the indication of progress might be useful when tracking down
where in a test a failure has happened, the same applies to most other
test helpers, which are quiet about success, so this single helper's
output stands out in an unpleasant way.  An alternative method for
showing progress information might to invent a --progress option that
runs tests with "set -x", or until that is available, to run tests
using commands like

	prove -v -j2 --shuffle --exec='sh -x' t2202-add-addremove.sh

Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Jonathan Nieder authored and Junio C Hamano committed May 22, 2011
1 parent ea2ca44 commit f5b7ce1
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions t/test-lib.sh
Original file line number Diff line number Diff line change
Expand Up @@ -731,12 +731,11 @@ test_expect_code () {
exit_code=$?
if test $exit_code = $want_code
then
echo >&2 "test_expect_code: command exited with $exit_code: $*"
return 0
else
echo >&2 "test_expect_code: command exited with $exit_code, we wanted $want_code $*"
return 1
fi

echo >&2 "test_expect_code: command exited with $exit_code, we wanted $want_code $*"
return 1
}

# test_cmp is a helper function to compare actual and expected output.
Expand Down

0 comments on commit f5b7ce1

Please sign in to comment.