Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
mergetool-lib: fix default tool selection
When no diff nor merge tool is specified (config, option), mergetool-lib
is supposed to choose a default tool from a set of tools. That set is
constructed dynamically depending on the environment (graphical, editor
setting) as a space separated string of tool names.

719518f (mergetool--lib: set IFS for difftool and mergetool, 2015-05-20)
introduced a newline as IFS which breaks the parsing of the space
separated list into items, resulting in a failed search for an available
tool.

Set IFS to a space locally for the tool search.

Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Michael J Gruber authored and Junio C Hamano committed Jun 19, 2015
1 parent 3e4f237 commit f67986b
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions git-mergetool--lib.sh
Expand Up @@ -305,6 +305,7 @@ guess_merge_tool () {
EOF

# Loop over each candidate and stop when a valid merge tool is found.
IFS=' '
for tool in $tools
do
is_available "$tool" && echo "$tool" && return 0
Expand Down

0 comments on commit f67986b

Please sign in to comment.