Skip to content

Commit

Permalink
git-web--browse: Fix check for /bin/start
Browse files Browse the repository at this point in the history
The previous check in git-web--browse for /bin/start used test -n
/bin/start, which was always true.  This lead to "start" being tried
first in the browser list.  On systems with upstart installed, "start"
exists and might be in the PATH, but it makes a poor choice for a web
browser.  Instead, test that /bin/start exists and is executable.

Signed-off-by: Todd Zullinger <tmz@pobox.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Todd Zullinger authored and Junio C Hamano committed Feb 9, 2009
1 parent df487ba commit f6b98e4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion git-web--browse.sh
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ if test -z "$browser" ; then
browser_candidates="open $browser_candidates"
fi
# /bin/start indicates MinGW
if test -n /bin/start; then
if test -x /bin/start; then
browser_candidates="start $browser_candidates"
fi

Expand Down

0 comments on commit f6b98e4

Please sign in to comment.