Skip to content

Commit

Permalink
rebase -X: do not clobber strategy
Browse files Browse the repository at this point in the history
If any strategy options are passed to -X, the strategy will always be
set to 'recursive'. According to the documentation, it should default to
'recursive' if it is not set, but it should be possible to set it to
other values.

This fixes a regression introduced in v1.7.3-rc0~67^2 (2010-07-29).

Signed-off-by: Martin von Zweigbergk <martin.von.zweigbergk@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Martin von Zweigbergk authored and Junio C Hamano committed Nov 10, 2010
1 parent 60aa9cf commit f772c34
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions git-rebase.sh
Original file line number Diff line number Diff line change
Expand Up @@ -311,10 +311,6 @@ do
esac
strategy_opts="$strategy_opts $(git rev-parse --sq-quote "--$newopt")"
do_merge=t
if test -n "$strategy"
then
strategy=recursive
fi
;;
-s=*|--s=*|--st=*|--str=*|--stra=*|--strat=*|--strate=*|\
--strateg=*|--strategy=*|\
Expand Down

0 comments on commit f772c34

Please sign in to comment.