Skip to content

Commit

Permalink
gitk: Fix bug in parsing multiple revision arguments
Browse files Browse the repository at this point in the history
If the user specified multiple revisions arguments on the command
line or for a view, we were passing the whole list of arguments to
git rev-parse as a single argument, and thus git rev-parse didn't
interpret it as revisions.  This fixes it by adding an eval so the
arguments get passed to git rev-parse as separate arguments.

Signed-off-by: Paul Mackerras <paulus@samba.org>
  • Loading branch information
Paul Mackerras committed Dec 7, 2007
1 parent 38dfe93 commit f78e7ab
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion gitk
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ proc start_rev_list {view} {
set vnextroot($view) 0
varcinit $view

set commits [exec git rev-parse --default HEAD --revs-only \
set commits [eval exec git rev-parse --default HEAD --revs-only \
$viewargs($view)]
set viewincl($view) {}
foreach c $commits {
Expand Down

0 comments on commit f78e7ab

Please sign in to comment.