Skip to content

Commit

Permalink
t4212: loosen far-in-future test for AIX
Browse files Browse the repository at this point in the history
One of the tests in t4212 checks our behavior when we feed
gmtime a date so far in the future that it gives up and
returns NULL. Some implementations, like AIX, may actually
just provide us a bogus result instead.

It's not worth it for us to come up with heuristics that
guess whether the return value is sensible or not. On good
platforms where gmtime reports the problem to us with NULL,
we will print the epoch value. On bad platforms, we will
print garbage.  But our test should be written for the
lowest common denominator so that it passes everywhere.

Reported-by: Charles Bailey <cbailey32@bloomberg.net>
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Jeff King authored and Junio C Hamano committed Apr 1, 2014
1 parent 6654754 commit f80d1f9
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions t/t4212-log-corrupt.sh
Original file line number Diff line number Diff line change
Expand Up @@ -77,11 +77,9 @@ test_expect_success 'date parser recognizes time_t overflow' '
'

# date is within 2^63-1, but enough to choke glibc's gmtime
test_expect_success 'absurdly far-in-future dates produce sentinel' '
test_expect_success 'absurdly far-in-future date' '
commit=$(munge_author_date HEAD 999999999999999999) &&
echo "Thu Jan 1 00:00:00 1970 +0000" >expect &&
git log -1 --format=%ad $commit >actual &&
test_cmp expect actual
git log -1 --format=%ad $commit
'

test_done

0 comments on commit f80d1f9

Please sign in to comment.