Skip to content

Commit

Permalink
Merge git://git.kernel.org/pub/scm/gitk/gitk
Browse files Browse the repository at this point in the history
* git://git.kernel.org/pub/scm/gitk/gitk:
  gitk: Fix possible infinite loop and display corruption
  • Loading branch information
Junio C Hamano committed Mar 2, 2009
2 parents f474c52 + 52b8ea9 commit f8c6288
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions gitk-git/gitk
Original file line number Diff line number Diff line change
Expand Up @@ -701,16 +701,17 @@ proc newvarc {view id} {
}

proc splitvarc {p v} {
global varcid varcstart varccommits varctok
global varcid varcstart varccommits varctok vtokmod
global vupptr vdownptr vleftptr vbackptr varcix varcrow vlastins

set oa $varcid($v,$p)
set otok [lindex $varctok($v) $oa]
set ac $varccommits($v,$oa)
set i [lsearch -exact $varccommits($v,$oa) $p]
if {$i <= 0} return
set na [llength $varctok($v)]
# "%" sorts before "0"...
set tok "[lindex $varctok($v) $oa]%[strrep $i]"
set tok "$otok%[strrep $i]"
lappend varctok($v) $tok
lappend varcrow($v) {}
lappend varcix($v) {}
Expand All @@ -730,6 +731,9 @@ proc splitvarc {p v} {
for {set b [lindex $vdownptr($v) $na]} {$b != 0} {set b [lindex $vleftptr($v) $b]} {
lset vupptr($v) $b $na
}
if {[string compare $otok $vtokmod($v)] <= 0} {
modify_arc $v $oa
}
}

proc renumbervarc {a v} {
Expand Down Expand Up @@ -3363,7 +3367,6 @@ proc external_blame {parent_idx {line {}}} {
# being given an absolute path...
set f [make_relative $f]
lappend cmdline $base_commit $f
puts "cmdline={$cmdline}"
if {[catch {eval exec $cmdline &} err]} {
error_popup "[mc "git gui blame: command failed:"] $err"
}
Expand Down Expand Up @@ -5731,7 +5734,6 @@ proc drawcommits {row {endrow {}}} {
optimize_rows $ro1 0 $r2
if {$need_redisplay || $nrows_drawn > 2000} {
clear_display
drawvisible
}

# make the lines join to already-drawn rows either side
Expand Down

0 comments on commit f8c6288

Please sign in to comment.