Skip to content

Commit

Permalink
Merge branch 'jc/deprecate'
Browse files Browse the repository at this point in the history
As previously announced, diff-stages and resolve are now gone.
  • Loading branch information
Junio C Hamano committed Feb 14, 2007
2 parents 6132bd5 + 4cc41a1 commit f8f2aaa
Show file tree
Hide file tree
Showing 16 changed files with 16 additions and 219 deletions.
2 changes: 0 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ git-daemon
git-diff
git-diff-files
git-diff-index
git-diff-stages
git-diff-tree
git-describe
git-fast-import
Expand Down Expand Up @@ -101,7 +100,6 @@ git-repo-config
git-request-pull
git-rerere
git-reset
git-resolve
git-rev-list
git-rev-parse
git-revert
Expand Down
2 changes: 0 additions & 2 deletions Documentation/cmd-list.perl
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,6 @@ sub format_one {
git-diff-files plumbinginterrogators
git-diff-index plumbinginterrogators
git-diff mainporcelain
git-diff-stages plumbinginterrogators
git-diff-tree plumbinginterrogators
git-fast-import ancillarymanipulators
git-fetch mainporcelain
Expand Down Expand Up @@ -149,7 +148,6 @@ sub format_one {
git-request-pull foreignscminterface
git-rerere ancillaryinterrogators
git-reset mainporcelain
git-resolve mainporcelain
git-revert mainporcelain
git-rev-list plumbinginterrogators
git-rev-parse ancillaryinterrogators
Expand Down
3 changes: 2 additions & 1 deletion Documentation/core-intro.txt
Original file line number Diff line number Diff line change
Expand Up @@ -587,4 +587,5 @@ stages to temporary files and calls a "merge" script on it:

git-merge-index git-merge-one-file hello.c

and that is what higher level `git resolve` is implemented with.
and that is what higher level `git merge -s resolve` is implemented
with.
8 changes: 4 additions & 4 deletions Documentation/core-tutorial.txt
Original file line number Diff line number Diff line change
Expand Up @@ -977,7 +977,7 @@ see more complex cases.
Now, let's pretend you are the one who did all the work in
`mybranch`, and the fruit of your hard work has finally been merged
to the `master` branch. Let's go back to `mybranch`, and run
resolve to get the "upstream changes" back to your branch.
`git merge` to get the "upstream changes" back to your branch.

------------
$ git checkout mybranch
Expand All @@ -996,7 +996,7 @@ Fast forward
----------------

Because your branch did not contain anything more than what are
already merged into the `master` branch, the resolve operation did
already merged into the `master` branch, the merge operation did
not actually do a merge. Instead, it just updated the top of
the tree of your branch to that of the `master` branch. This is
often called 'fast forward' merge.
Expand Down Expand Up @@ -1099,11 +1099,11 @@ programs, which are 'commit walkers'; they outlived their
usefulness when git Native and SSH transports were introduced,
and not used by `git pull` or `git push` scripts.

Once you fetch from the remote repository, you `resolve` that
Once you fetch from the remote repository, you `merge` that
with your current branch.

However -- it's such a common thing to `fetch` and then
immediately `resolve`, that it's called `git pull`, and you can
immediately `merge`, that it's called `git pull`, and you can
simply do

----------------
Expand Down
7 changes: 2 additions & 5 deletions Documentation/diffcore.txt
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ June 2005
Introduction
------------

The diff commands git-diff-index, git-diff-files, git-diff-tree, and
git-diff-stages can be told to manipulate differences they find in
The diff commands git-diff-index, git-diff-files, and git-diff-tree
can be told to manipulate differences they find in
unconventional ways before showing diff(1) output. The manipulation
is collectively called "diffcore transformation". This short note
describes what they are and how to use them to produce diff outputs
Expand All @@ -30,9 +30,6 @@ files:

- git-diff-tree compares contents of two "tree" objects;

- git-diff-stages compares contents of blobs at two stages in an
unmerged index file.

In all of these cases, the commands themselves compare
corresponding paths in the two sets of files. The result of
comparison is passed from these commands to what is internally
Expand Down
42 changes: 0 additions & 42 deletions Documentation/git-diff-stages.txt

This file was deleted.

38 changes: 0 additions & 38 deletions Documentation/git-resolve.txt

This file was deleted.

9 changes: 1 addition & 8 deletions Documentation/howto/revert-branch-rebase.txt
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ Fortunately I did not have to; what I have in the current branch

------------------------------------------------
$ git checkout master
$ git resolve master revert-c99 fast ;# this should be a fast forward
$ git merge revert-c99 ;# this should be a fast forward
Updating from 10d781b9caa4f71495c7b34963bef137216f86a8 to e3a693c...
cache.h | 8 ++++----
commit.c | 2 +-
Expand All @@ -95,13 +95,6 @@ Updating from 10d781b9caa4f71495c7b34963bef137216f86a8 to e3a693c...
5 files changed, 8 insertions(+), 8 deletions(-)
------------------------------------------------

The 'fast' in the above 'git resolve' is not a magic. I knew this
'resolve' would result in a fast forward merge, and if not, there is
something very wrong (so I would do 'git reset' on the 'master' branch
and examine the situation). When a fast forward merge is done, the
message parameter to 'git resolve' is discarded, because no new commit
is created. You could have said 'junk' or 'nothing' there as well.

There is no need to redo the test at this point. We fast forwarded
and we know 'master' matches 'revert-c99' exactly. In fact:

Expand Down
2 changes: 1 addition & 1 deletion Documentation/user-manual.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2755,7 +2755,7 @@ stages to temporary files and calls a "merge" script on it:
$ git-merge-index git-merge-one-file hello.c
-------------------------------------------------

and that is what higher level `git resolve` is implemented with.
and that is what higher level `git merge -s resolve` is implemented with.

How git stores objects efficiently: pack files
----------------------------------------------
Expand Down
3 changes: 1 addition & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ SCRIPT_SH = \
git-merge-one-file.sh git-parse-remote.sh \
git-pull.sh git-rebase.sh \
git-repack.sh git-request-pull.sh git-reset.sh \
git-resolve.sh git-revert.sh git-sh-setup.sh \
git-revert.sh git-sh-setup.sh \
git-tag.sh git-verify-tag.sh \
git-applymbox.sh git-applypatch.sh git-am.sh \
git-merge.sh git-merge-stupid.sh git-merge-octopus.sh \
Expand Down Expand Up @@ -280,7 +280,6 @@ BUILTIN_OBJS = \
builtin-diff.o \
builtin-diff-files.o \
builtin-diff-index.o \
builtin-diff-stages.o \
builtin-diff-tree.o \
builtin-fmt-merge-msg.o \
builtin-for-each-ref.o \
Expand Down
107 changes: 0 additions & 107 deletions builtin-diff-stages.c

This file was deleted.

1 change: 0 additions & 1 deletion builtin.h
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ extern int cmd_describe(int argc, const char **argv, const char *prefix);
extern int cmd_diff_files(int argc, const char **argv, const char *prefix);
extern int cmd_diff_index(int argc, const char **argv, const char *prefix);
extern int cmd_diff(int argc, const char **argv, const char *prefix);
extern int cmd_diff_stages(int argc, const char **argv, const char *prefix);
extern int cmd_diff_tree(int argc, const char **argv, const char *prefix);
extern int cmd_fmt_merge_msg(int argc, const char **argv, const char *prefix);
extern int cmd_for_each_ref(int argc, const char **argv, const char *prefix);
Expand Down
2 changes: 0 additions & 2 deletions contrib/completion/git-completion.bash
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,6 @@ __git_commands ()
cvsimport) : import;;
cvsserver) : daemon;;
daemon) : daemon;;
diff-stages) : nobody uses it;;
fast-import) : import;;
fsck-objects) : plumbing;;
fetch-pack) : plumbing;;
Expand Down Expand Up @@ -298,7 +297,6 @@ __git_commands ()
reflog) : plumbing;;
repo-config) : plumbing;;
rerere) : plumbing;;
resolve) : dead dont use;;
rev-list) : plumbing;;
rev-parse) : plumbing;;
runstatus) : plumbing;;
Expand Down
File renamed without changes.
1 change: 0 additions & 1 deletion git.c
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,6 @@ static void handle_internal_command(int argc, const char **argv, char **envp)
{ "diff", cmd_diff, RUN_SETUP | USE_PAGER },
{ "diff-files", cmd_diff_files, RUN_SETUP },
{ "diff-index", cmd_diff_index, RUN_SETUP },
{ "diff-stages", cmd_diff_stages, RUN_SETUP },
{ "diff-tree", cmd_diff_tree, RUN_SETUP },
{ "fmt-merge-msg", cmd_fmt_merge_msg, RUN_SETUP },
{ "for-each-ref", cmd_for_each_ref, RUN_SETUP },
Expand Down
8 changes: 5 additions & 3 deletions t/t1200-tutorial.sh
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,9 @@ echo "Play, play, play" >>hello
echo "Lots of fun" >>example
git commit -m 'Some fun.' -i hello example

test_expect_failure 'git resolve now fails' 'git resolve HEAD mybranch "Merge work in mybranch"'
test_expect_failure 'git resolve now fails' '
git merge -m "Merge work in mybranch" mybranch
'

cat > hello << EOF
Hello World
Expand Down Expand Up @@ -134,8 +136,8 @@ Updating from VARIABLE to VARIABLE
2 files changed, 2 insertions(+), 0 deletions(-)
EOF

git resolve HEAD master "Merge upstream changes." | \
sed -e "1s/[0-9a-f]\{40\}/VARIABLE/g" > resolve.output
git merge -s "Merge upstream changes." master | \
sed -e "1s/[0-9a-f]\{40\}/VARIABLE/g" >resolve.output
test_expect_success 'git resolve' 'cmp resolve.expect resolve.output'

cat > show-branch2.expect << EOF
Expand Down

0 comments on commit f8f2aaa

Please sign in to comment.