Skip to content

Commit

Permalink
Merge branch 'hv/link-alt-odb-entry'
Browse files Browse the repository at this point in the history
The code to avoid mistaken attempt to add the object directory
itself as its own alternate could read beyond end of a string while
comparison.

* hv/link-alt-odb-entry:
  link_alt_odb_entry: fix read over array bounds reported by valgrind
  • Loading branch information
Junio C Hamano committed Jul 30, 2012
2 parents dff9d65 + cb2912c commit fbea95c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sha1_file.c
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ static int link_alt_odb_entry(const char * entry, int len, const char * relative
return -1;
}
}
if (!memcmp(ent->base, objdir, pfxlen)) {
if (!strcmp(ent->base, objdir)) {
free(ent);
return -1;
}
Expand Down

0 comments on commit fbea95c

Please sign in to comment.