Skip to content

Commit

Permalink
[PATCH] libata-dev: filter out noisy ATAPI error messages
Browse files Browse the repository at this point in the history
Changes:
 - Filter out ATAPI packet command error messages in ata_pio_error()
 - Filter out ATAPI packet command error messages in ata_host_intr()

Signed-off-by: Albert Lee <albertcc@tw.ibm.com>

======
Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
  • Loading branch information
Albert Lee authored and Jeff Garzik committed Jan 18, 2006
1 parent a4f1661 commit 000080c
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions drivers/scsi/libata-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -3520,11 +3520,12 @@ static void ata_pio_error(struct ata_port *ap)
{
struct ata_queued_cmd *qc;

printk(KERN_WARNING "ata%u: PIO error\n", ap->id);

qc = ata_qc_from_tag(ap, ap->active_tag);
assert(qc != NULL);

if (qc->tf.command != ATA_CMD_PACKET)
printk(KERN_WARNING "ata%u: PIO error\n", ap->id);

/* make sure qc->err_mask is available to
* know what's wrong and recover
*/
Expand Down Expand Up @@ -4404,8 +4405,9 @@ inline unsigned int ata_host_intr (struct ata_port *ap,
break;

case HSM_ST_ERR:
printk(KERN_ERR "ata%u: command error, drv_stat 0x%x host_stat 0x%x\n",
ap->id, status, host_stat);
if (qc->tf.command != ATA_CMD_PACKET)
printk(KERN_ERR "ata%u: command error, drv_stat 0x%x host_stat 0x%x\n",
ap->id, status, host_stat);

/* make sure qc->err_mask is available to
* know what's wrong and recover
Expand Down

0 comments on commit 000080c

Please sign in to comment.