Skip to content

Commit

Permalink
net: Fix build warning in sock_bindtodevice().
Browse files Browse the repository at this point in the history
net/core/sock.c: In function 'sock_setsockopt':
net/core/sock.c:396: warning: 'index' may be used uninitialized in this function
net/core/sock.c:396: note: 'index' was declared here

GCC can't see that all paths initialize index, so just
set it to the default (0) and eliminate the specific
code block that handles the null device name string.

Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
David S. Miller committed Nov 6, 2009
1 parent baac856 commit 000ba2e
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions net/core/sock.c
Original file line number Diff line number Diff line change
Expand Up @@ -417,9 +417,8 @@ static int sock_bindtodevice(struct sock *sk, char __user *optval, int optlen)
if (copy_from_user(devname, optval, optlen))
goto out;

if (devname[0] == '\0') {
index = 0;
} else {
index = 0;
if (devname[0] != '\0') {
struct net_device *dev;

rcu_read_lock();
Expand Down

0 comments on commit 000ba2e

Please sign in to comment.