Skip to content

Commit

Permalink
drivers/net: Move a dereference below a NULL test
Browse files Browse the repository at this point in the history
If the NULL test is necessary, then the dereferences should be moved below
the NULL test.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
type T;
expression E,E1;
identifier i,fld;
statement S;
@@

- T i = E->fld;
+ T i;
  ... when != E=E1
      when != i
  BUG_ON (E == NULL||...);
+ i = E->fld;
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Julia Lawall authored and David S. Miller committed Jul 21, 2009
1 parent acb9c1b commit 0021195
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions drivers/net/ibm_newemac/rgmii.c
Original file line number Diff line number Diff line change
Expand Up @@ -188,11 +188,12 @@ void rgmii_put_mdio(struct of_device *ofdev, int input)
void rgmii_detach(struct of_device *ofdev, int input)
{
struct rgmii_instance *dev = dev_get_drvdata(&ofdev->dev);
struct rgmii_regs __iomem *p = dev->base;

mutex_lock(&dev->lock);
struct rgmii_regs __iomem *p;

BUG_ON(!dev || dev->users == 0);
p = dev->base;

mutex_lock(&dev->lock);

RGMII_DBG(dev, "detach(%d)" NL, input);

Expand Down

0 comments on commit 0021195

Please sign in to comment.