Skip to content

Commit

Permalink
perf inject: Don't use globals where not needed to
Browse files Browse the repository at this point in the history
Some variables were global but used in just one function, so move it to
where it belongs.

Leftover from patch at the beggining of this series.

Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Namhyung Kim <namhyung@gmail.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/n/tip-9cer20zhw64wbxyb0zias82i@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
  • Loading branch information
Arnaldo Carvalho de Melo committed Oct 2, 2012
1 parent 61eaa3b commit 002439e
Showing 1 changed file with 6 additions and 7 deletions.
13 changes: 6 additions & 7 deletions tools/perf/builtin-inject.c
Original file line number Diff line number Diff line change
Expand Up @@ -242,11 +242,6 @@ static int __cmd_inject(struct perf_inject *inject)
return ret;
}

static const char * const report_usage[] = {
"perf inject [<options>]",
NULL
};

int cmd_inject(int argc, const char **argv, const char *prefix __maybe_unused)
{
struct perf_inject inject = {
Expand All @@ -273,14 +268,18 @@ int cmd_inject(int argc, const char **argv, const char *prefix __maybe_unused)
"be more verbose (show build ids, etc)"),
OPT_END()
};
const char * const inject_usage[] = {
"perf inject [<options>]",
NULL
};

argc = parse_options(argc, argv, options, report_usage, 0);
argc = parse_options(argc, argv, options, inject_usage, 0);

/*
* Any (unrecognized) arguments left?
*/
if (argc)
usage_with_options(report_usage, options);
usage_with_options(inject_usage, options);

if (symbol__init() < 0)
return -1;
Expand Down

0 comments on commit 002439e

Please sign in to comment.