Skip to content

Commit

Permalink
[PATCH] x86-64: do not always end the stack trace with ULONG_MAX
Browse files Browse the repository at this point in the history
It makes more sense to end the stack trace with ULONG_MAX only if
nr_entries < max_entries.  Otherwise, we lose one entry in the long stack
traces and cannot know whether the trace was complete or not.

Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
Signed-off-by: Andi Kleen <ak@suse.de>
Cc: Andi Kleen <ak@suse.de>
Cc: Jan Beulich <jbeulich@novell.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
  • Loading branch information
Catalin Marinas authored and Andi Kleen committed Feb 13, 2007
1 parent 5558870 commit 006e84e
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions arch/x86_64/kernel/stacktrace.c
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ static void save_stack_address(void *data, unsigned long addr)
trace->skip--;
return;
}
if (trace->nr_entries < trace->max_entries - 1)
if (trace->nr_entries < trace->max_entries)
trace->entries[trace->nr_entries++] = addr;
}

Expand All @@ -49,7 +49,8 @@ static struct stacktrace_ops save_stack_ops = {
void save_stack_trace(struct stack_trace *trace, struct task_struct *task)
{
dump_trace(task, NULL, NULL, &save_stack_ops, trace);
trace->entries[trace->nr_entries++] = ULONG_MAX;
if (trace->nr_entries < trace->max_entries)
trace->entries[trace->nr_entries++] = ULONG_MAX;
}
EXPORT_SYMBOL(save_stack_trace);

0 comments on commit 006e84e

Please sign in to comment.