Skip to content

Commit

Permalink
Fix oprofile configuration breakage
Browse files Browse the repository at this point in the history
The cleanup 09caded broke the oprofile
configuration for MIPS by allowing oprofile support to be built for
kernel models where oprofile doesn't have a chance in hell to work.

Just a dependecy list on a number of architectures is - surprise - broken
and should as per past discussions probably in most considered to be
broken in most cases.  So I introduce a dependency for the oprofile
configuration on ARCH_SUPPORTS_OPROFILE.

Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Ralf Baechle authored and Linus Torvalds committed Dec 6, 2007
1 parent 7e1fb76 commit 00a5825
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
4 changes: 4 additions & 0 deletions arch/mips/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -714,6 +714,10 @@ config ARCH_HAS_ILOG2_U64
bool
default n

config ARCH_SUPPORTS_OPROFILE
bool
default y if !MIPS_MT_SMTC

config GENERIC_FIND_NEXT_BIT
bool
default y
Expand Down
2 changes: 1 addition & 1 deletion kernel/Kconfig.instrumentation
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ config PROFILING
config OPROFILE
tristate "OProfile system profiling (EXPERIMENTAL)"
depends on PROFILING
depends on (ALPHA || ARM || BLACKFIN || X86_32 || IA64 || M32R || MIPS || PARISC || PPC || S390 || SUPERH || SPARC || X86_64) && !UML
depends on (ARCH_SUPPORTS_OPROFILE || ALPHA || ARM || BLACKFIN || X86_32 || IA64 || M32R || PARISC || PPC || S390 || SUPERH || SPARC || X86_64) && !UML
help
OProfile is a profiling system capable of profiling the
whole system, include the kernel, kernel modules, libraries,
Expand Down

0 comments on commit 00a5825

Please sign in to comment.