Skip to content

Commit

Permalink
ARM: OMAP: Remove unnecessary omap2_globals.
Browse files Browse the repository at this point in the history
This patch removes unnecessary omap2_globals and pass the global structures
directly as function argument.

The proposed cleanup was suggested by Russell King <rmk+kernel@arm.linux.org.uk>

Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
  • Loading branch information
Santosh Shilimkar authored and Tony Lindgren committed May 25, 2009
1 parent af5703f commit 00aeeff
Showing 1 changed file with 4 additions and 9 deletions.
13 changes: 4 additions & 9 deletions arch/arm/plat-omap/common.c
Original file line number Diff line number Diff line change
Expand Up @@ -287,9 +287,7 @@ arch_initcall(omap_init_clocksource_32k);

#if defined(CONFIG_ARCH_OMAP2) || defined(CONFIG_ARCH_OMAP3)

static struct omap_globals *omap2_globals;

static void __init __omap2_set_globals(void)
static void __init __omap2_set_globals(struct omap_globals *omap2_globals)
{
omap2_set_globals_tap(omap2_globals);
omap2_set_globals_sdrc(omap2_globals);
Expand All @@ -313,8 +311,7 @@ static struct omap_globals omap242x_globals = {

void __init omap2_set_globals_242x(void)
{
omap2_globals = &omap242x_globals;
__omap2_set_globals();
__omap2_set_globals(&omap242x_globals);
}
#endif

Expand All @@ -332,8 +329,7 @@ static struct omap_globals omap243x_globals = {

void __init omap2_set_globals_243x(void)
{
omap2_globals = &omap243x_globals;
__omap2_set_globals();
__omap2_set_globals(&omap243x_globals);
}
#endif

Expand All @@ -351,8 +347,7 @@ static struct omap_globals omap343x_globals = {

void __init omap2_set_globals_343x(void)
{
omap2_globals = &omap343x_globals;
__omap2_set_globals();
__omap2_set_globals(&omap343x_globals);
}
#endif

0 comments on commit 00aeeff

Please sign in to comment.