Skip to content

Commit

Permalink
USB: gadget: f_mass_storage: remove needless complete()
Browse files Browse the repository at this point in the history
This commit removes call to the complete() function done in
fsg_unbind() which was never needed there but was a leftover
form file_storage.c.

Signed-off-by: Michal Nazarewicz <mina86@mina86.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Michal Nazarewicz authored and Greg Kroah-Hartman committed Nov 11, 2010
1 parent fe52f79 commit 00cb636
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions drivers/usb/gadget/f_mass_storage.c
Original file line number Diff line number Diff line change
Expand Up @@ -2657,7 +2657,7 @@ static int fsg_main_thread(void *common_)
up_write(&common->filesem);
}

/* Let the unbind and cleanup routines know the thread has exited */
/* Let fsg_unbind() know the thread has exited */
complete_and_exit(&common->thread_notifier, 0);
}

Expand Down Expand Up @@ -2906,9 +2906,6 @@ static void fsg_common_release(struct kref *ref)
if (common->state != FSG_STATE_TERMINATED) {
raise_exception(common, FSG_STATE_EXIT);
wait_for_completion(&common->thread_notifier);

/* The cleanup routine waits for this completion also */
complete(&common->thread_notifier);
}

if (likely(common->luns)) {
Expand Down

0 comments on commit 00cb636

Please sign in to comment.