Skip to content

Commit

Permalink
pwm: renesas-tpu: fix return value check in tpu_probe()
Browse files Browse the repository at this point in the history
In case of error, the function devm_ioremap_resource() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should
be replaced with IS_ERR().

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Reviewed-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
  • Loading branch information
Wei Yongjun authored and Thierry Reding committed Jun 25, 2013
1 parent 99b82ab commit 00cf99e
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions drivers/pwm/pwm-renesas-tpu.c
Original file line number Diff line number Diff line change
Expand Up @@ -410,10 +410,8 @@ static int tpu_probe(struct platform_device *pdev)
}

tpu->base = devm_ioremap_resource(&pdev->dev, res);
if (tpu->base == NULL) {
dev_err(&pdev->dev, "failed to remap I/O memory\n");
return -ENXIO;
}
if (IS_ERR(tpu->base))
return PTR_ERR(tpu->base);

tpu->clk = devm_clk_get(&pdev->dev, NULL);
if (IS_ERR(tpu->clk)) {
Expand Down

0 comments on commit 00cf99e

Please sign in to comment.