Skip to content

Commit

Permalink
x86: numachip: Fix 16-bit APIC ID truncation
Browse files Browse the repository at this point in the history
Prevent 16-bit APIC IDs being truncated by using correct mask. This fixes
booting large systems, where the wrong core would receive the startup and
init IPIs, causing hanging.

Signed-off-by: Daniel J Blueman <daniel@numascale.com>
Cc: Steffen Persvold <sp@numascale.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Link: http://lkml.kernel.org/r/1415089784-28779-1-git-send-email-daniel@numascale.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
  • Loading branch information
Daniel J Blueman authored and Thomas Gleixner committed Nov 4, 2014
1 parent 0df1f24 commit 00e7977
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion arch/x86/kernel/apic/apic_numachip.c
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ static unsigned int get_apic_id(unsigned long x)
unsigned int id;

rdmsrl(MSR_FAM10H_NODE_ID, value);
id = ((x >> 24) & 0xffU) | ((value << 2) & 0x3f00U);
id = ((x >> 24) & 0xffU) | ((value << 2) & 0xff00U);

return id;
}
Expand Down

0 comments on commit 00e7977

Please sign in to comment.