Skip to content

Commit

Permalink
ksym_tracer: NIL-terminate user input filter
Browse files Browse the repository at this point in the history
Make sure the user input string is NULL-terminated.

Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: "K.Prasad" <prasad@linux.vnet.ibm.com>
Cc: Alan Stern <stern@rowland.harvard.edu>
Cc: Steven Rostedt <rostedt@goodmis.org>
LKML-Reference: <4A52E300.7020601@cn.fujitsu.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Li Zefan authored and Ingo Molnar committed Jul 10, 2009
1 parent 92cf9f8 commit 011ed56
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions kernel/trace/trace_ksym.c
Original file line number Diff line number Diff line change
Expand Up @@ -264,18 +264,15 @@ static ssize_t ksym_trace_filter_write(struct file *file,
unsigned long ksym_addr = 0;
int ret, op, changed = 0;

/* Ignore echo "" > ksym_trace_filter */
if (count == 0)
return 0;

input_string = kzalloc(count, GFP_KERNEL);
input_string = kzalloc(count + 1, GFP_KERNEL);
if (!input_string)
return -ENOMEM;

if (copy_from_user(input_string, buffer, count)) {
kfree(input_string);
return -EFAULT;
}
input_string[count] = '\0';

ret = op = parse_ksym_trace_str(input_string, &ksymname, &ksym_addr);
if (ret < 0) {
Expand Down

0 comments on commit 011ed56

Please sign in to comment.