Skip to content

Commit

Permalink
[PATCH] Change panic_on_oops message to "Fatal exception"
Browse files Browse the repository at this point in the history
Previously the message was "Fatal exception: panic_on_oops", as introduced
in a recent patch whith removed a somewhat dangerous call to ssleep() in
the panic_on_oops path.  However, Paul Mackerras suggested that this was
somewhat confusing, leadind people to believe that it was panic_on_oops
that was the root cause of the fatal exception.  On his suggestion, this
patch changes the message to simply "Fatal exception".  A suitable oops
message should already have been displayed.

Signed-off-by: Simon Horman <horms@verge.net.au>
Cc: Paul Mackerras <paulus@samba.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Horms authored and Greg Kroah-Hartman committed Aug 14, 2006
1 parent 485311a commit 012c437
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion arch/arm/kernel/traps.c
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ NORET_TYPE void die(const char *str, struct pt_regs *regs, int err)
spin_unlock_irq(&die_lock);

if (panic_on_oops)
panic("Fatal exception: panic_on_oops");
panic("Fatal exception");

do_exit(SIGSEGV);
}
Expand Down
2 changes: 1 addition & 1 deletion arch/i386/kernel/traps.c
Original file line number Diff line number Diff line change
Expand Up @@ -454,7 +454,7 @@ void die(const char * str, struct pt_regs * regs, long err)
panic("Fatal exception in interrupt");

if (panic_on_oops)
panic("Fatal exception: panic_on_oops");
panic("Fatal exception");

oops_exit();
do_exit(SIGSEGV);
Expand Down
2 changes: 1 addition & 1 deletion arch/ia64/kernel/traps.c
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ die (const char *str, struct pt_regs *regs, long err)
spin_unlock_irq(&die.lock);

if (panic_on_oops)
panic("Fatal exception: panic_on_oops");
panic("Fatal exception");

do_exit(SIGSEGV);
}
Expand Down
2 changes: 1 addition & 1 deletion arch/powerpc/kernel/traps.c
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ int die(const char *str, struct pt_regs *regs, long err)
panic("Fatal exception in interrupt");

if (panic_on_oops)
panic("Fatal exception: panic_on_oops");
panic("Fatal exception");

do_exit(err);

Expand Down
2 changes: 1 addition & 1 deletion arch/x86_64/kernel/traps.c
Original file line number Diff line number Diff line change
Expand Up @@ -529,7 +529,7 @@ void __kprobes oops_end(unsigned long flags)
/* Nest count reaches zero, release the lock. */
spin_unlock_irqrestore(&die_lock, flags);
if (panic_on_oops)
panic("Fatal exception: panic_on_oops");
panic("Fatal exception");
}

void __kprobes __die(const char * str, struct pt_regs * regs, long err)
Expand Down
2 changes: 1 addition & 1 deletion arch/xtensa/kernel/traps.c
Original file line number Diff line number Diff line change
Expand Up @@ -488,7 +488,7 @@ void die(const char * str, struct pt_regs * regs, long err)
panic("Fatal exception in interrupt");

if (panic_on_oops)
panic("Fatal exception: panic_on_oops");
panic("Fatal exception");

do_exit(err);
}
Expand Down

0 comments on commit 012c437

Please sign in to comment.