Skip to content

Commit

Permalink
serial: kill USF_CLOSING_* definitions
Browse files Browse the repository at this point in the history
The serial layer for some reason uses different defines for the special
case close delays and then conditionally switches to/from the normal ones
in the ioctls.

Remove this rather pointless abstraction

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Alan Cox authored and Live-CD User committed Sep 19, 2009
1 parent b58d13a commit 016af53
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
6 changes: 3 additions & 3 deletions drivers/serial/serial_core.c
Original file line number Diff line number Diff line change
Expand Up @@ -652,7 +652,7 @@ static int uart_get_info(struct uart_state *state,
tmp.xmit_fifo_size = uport->fifosize;
tmp.baud_base = uport->uartclk / 16;
tmp.close_delay = port->close_delay / 10;
tmp.closing_wait = port->closing_wait == USF_CLOSING_WAIT_NONE ?
tmp.closing_wait = port->closing_wait == ASYNC_CLOSING_WAIT_NONE ?
ASYNC_CLOSING_WAIT_NONE :
port->closing_wait / 10;
tmp.custom_divisor = uport->custom_divisor;
Expand Down Expand Up @@ -690,7 +690,7 @@ static int uart_set_info(struct uart_state *state,
new_serial.irq = irq_canonicalize(new_serial.irq);
close_delay = new_serial.close_delay * 10;
closing_wait = new_serial.closing_wait == ASYNC_CLOSING_WAIT_NONE ?
USF_CLOSING_WAIT_NONE : new_serial.closing_wait * 10;
ASYNC_CLOSING_WAIT_NONE : new_serial.closing_wait * 10;

/*
* This semaphore protects port->count. It is also
Expand Down Expand Up @@ -1307,7 +1307,7 @@ static void uart_close(struct tty_struct *tty, struct file *filp)
*/
tty->closing = 1;

if (port->closing_wait != USF_CLOSING_WAIT_NONE)
if (port->closing_wait != ASYNC_CLOSING_WAIT_NONE)
tty_wait_until_sent(tty, msecs_to_jiffies(port->closing_wait));

/*
Expand Down
3 changes: 0 additions & 3 deletions include/linux/serial_core.h
Original file line number Diff line number Diff line change
Expand Up @@ -342,9 +342,6 @@ struct uart_port {
struct uart_state {
struct tty_port port;

#define USF_CLOSING_WAIT_INF (0)
#define USF_CLOSING_WAIT_NONE (~0U)

int pm_state;
struct circ_buf xmit;

Expand Down

0 comments on commit 016af53

Please sign in to comment.