Skip to content

Commit

Permalink
mx3fb: fix regression with uninitalized fb_info->mm_lock mutex
Browse files Browse the repository at this point in the history
Remove call to the mx3fb_set_par() and the mx3fb_blank() before the
register_framebuffer().

This fixes a problem with uninitialized the fb_info->mm_lock mutex
introduced by the commit 537a1bf " fbdev: add mutex for fb_mmap
locking"

Signed-off-by: Krzysztof Helt <krzysztof.h1@wp.pl>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Krzysztof Helt authored and Linus Torvalds committed Jul 10, 2009
1 parent afecb0d commit 016d356
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions drivers/video/mx3fb.c
Original file line number Diff line number Diff line change
Expand Up @@ -1365,11 +1365,6 @@ static int init_fb_chan(struct mx3fb_data *mx3fb, struct idmac_channel *ichan)
init_completion(&mx3fbi->flip_cmpl);
disable_irq(ichan->eof_irq);
dev_dbg(mx3fb->dev, "disabling irq %d\n", ichan->eof_irq);
ret = mx3fb_set_par(fbi);
if (ret < 0)
goto esetpar;

mx3fb_blank(FB_BLANK_UNBLANK, fbi);

dev_info(dev, "registered, using mode %s\n", fb_mode);

Expand Down

0 comments on commit 016d356

Please sign in to comment.