Skip to content

Commit

Permalink
drivers/video/auo_k190x.c: drop kfree of devm_kzalloc's data
Browse files Browse the repository at this point in the history
Using kfree to free data allocated with devm_kzalloc causes double frees.

The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression x;
@@

x = devm_kzalloc(...)
...
?-kfree(x);
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
  • Loading branch information
Julia Lawall authored and Florian Tobias Schandinat committed Aug 23, 2012
1 parent 72caa5f commit 01817d1
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions drivers/video/auo_k190x.c
Original file line number Diff line number Diff line change
Expand Up @@ -987,7 +987,6 @@ int __devinit auok190x_common_probe(struct platform_device *pdev,
fb_dealloc_cmap(&info->cmap);
err_cmap:
fb_deferred_io_cleanup(info);
kfree(info->fbdefio);
err_defio:
vfree((void *)info->screen_base);
err_irq:
Expand Down Expand Up @@ -1022,7 +1021,6 @@ int __devexit auok190x_common_remove(struct platform_device *pdev)
fb_dealloc_cmap(&info->cmap);

fb_deferred_io_cleanup(info);
kfree(info->fbdefio);

vfree((void *)info->screen_base);

Expand Down

0 comments on commit 01817d1

Please sign in to comment.