Skip to content

Commit

Permalink
phy: miphy28lp: Convert to devm_kcalloc and fix wrong sizof
Browse files Browse the repository at this point in the history
Prefer devm_kcalloc over devm_kzalloc with multiply.
In additional, use sizeof(phy) is incorrect, fix it.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Gabriel Fernandez<gabriel.fernandez@linaro.org>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
  • Loading branch information
Axel Lin authored and Kishon Vijay Abraham I committed Mar 13, 2015
1 parent d8d5294 commit 018e6ff
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions drivers/phy/phy-miphy28lp.c
Original file line number Diff line number Diff line change
Expand Up @@ -1209,9 +1209,8 @@ static int miphy28lp_probe(struct platform_device *pdev)
return -ENOMEM;

miphy_dev->nphys = of_get_child_count(np);
miphy_dev->phys = devm_kzalloc(&pdev->dev,
sizeof(phy) * miphy_dev->nphys,
GFP_KERNEL);
miphy_dev->phys = devm_kcalloc(&pdev->dev, miphy_dev->nphys,
sizeof(*miphy_dev->phys), GFP_KERNEL);
if (!miphy_dev->phys)
return -ENOMEM;

Expand Down

0 comments on commit 018e6ff

Please sign in to comment.