Skip to content

Commit

Permalink
smsc95xx: remove unused completion struct
Browse files Browse the repository at this point in the history
Oliver Neukum spotted the useless complete() in our async callback.  On
closer inspection, the entire completion struct is unused.  This patch
removes it.

Signed-off-by: Steve Glendinning <steve.glendinning@smsc.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Steve Glendinning authored and David S. Miller committed Jan 26, 2009
1 parent 0db155d commit 01a1ac4
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions drivers/net/usb/smsc95xx.c
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ struct smsc95xx_priv {

struct usb_context {
struct usb_ctrlrequest req;
struct completion notify;
struct usbnet *dev;
};

Expand Down Expand Up @@ -316,8 +315,6 @@ static void smsc95xx_async_cmd_callback(struct urb *urb, struct pt_regs *regs)
if (status < 0)
devwarn(dev, "async callback failed with %d", status);

complete(&usb_context->notify);

kfree(usb_context);
usb_free_urb(urb);
}
Expand Down Expand Up @@ -348,7 +345,6 @@ static int smsc95xx_write_reg_async(struct usbnet *dev, u16 index, u32 *data)
usb_context->req.wValue = 00;
usb_context->req.wIndex = cpu_to_le16(index);
usb_context->req.wLength = cpu_to_le16(size);
init_completion(&usb_context->notify);

usb_fill_control_urb(urb, dev->udev, usb_sndctrlpipe(dev->udev, 0),
(void *)&usb_context->req, data, size,
Expand Down

0 comments on commit 01a1ac4

Please sign in to comment.