Skip to content

Commit

Permalink
ASoC: palm27x: register card in platform_driver probe
Browse files Browse the repository at this point in the history
Remove creation of an soc-audio device from the machine platform_driver probe
function, and add a call to snd_soc_register_card() instead.

The current code still works, but this mechanism has been deprecated, if I'm not
mistaken.  The ASoC core code produces the warning "ASoC: machine Palm/PXA27x
should use snd_soc_register_card()"

Signed-off-by: Mike Dunn <mikedunn@newsguy.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
  • Loading branch information
Mike Dunn authored and Mark Brown committed Jan 2, 2013
1 parent 016fb39 commit 01a61f4
Showing 1 changed file with 6 additions and 17 deletions.
23 changes: 6 additions & 17 deletions sound/soc/pxa/palm27x.c
Original file line number Diff line number Diff line change
Expand Up @@ -144,8 +144,6 @@ static struct snd_soc_card palm27x_asoc = {
.num_dapm_routes = ARRAY_SIZE(audio_map)
};

static struct platform_device *palm27x_snd_device;

static int palm27x_asoc_probe(struct platform_device *pdev)
{
int ret;
Expand All @@ -162,27 +160,18 @@ static int palm27x_asoc_probe(struct platform_device *pdev)
hs_jack_gpios[0].gpio = ((struct palm27x_asoc_info *)
(pdev->dev.platform_data))->jack_gpio;

palm27x_snd_device = platform_device_alloc("soc-audio", -1);
if (!palm27x_snd_device)
return -ENOMEM;

platform_set_drvdata(palm27x_snd_device, &palm27x_asoc);
ret = platform_device_add(palm27x_snd_device);

if (ret != 0)
goto put_device;

return 0;

put_device:
platform_device_put(palm27x_snd_device);
palm27x_asoc.dev = &pdev->dev;

ret = snd_soc_register_card(&palm27x_asoc);
if (ret)
dev_err(&pdev->dev, "snd_soc_register_card() failed: %d\n",
ret);
return ret;
}

static int palm27x_asoc_remove(struct platform_device *pdev)
{
platform_device_unregister(palm27x_snd_device);
snd_soc_unregister_card(&palm27x_asoc);
return 0;
}

Expand Down

0 comments on commit 01a61f4

Please sign in to comment.