Skip to content

Commit

Permalink
sfc: Remove efx_nic_dummy_op_int() as redundant with efx_port_dummy_o…
Browse files Browse the repository at this point in the history
…p_int()

Update comment on the dummy operation implementations.

Line up the board operation initialisers.

Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
  • Loading branch information
Ben Hutchings authored and Jeff Garzik committed Sep 3, 2008
1 parent 740847d commit 01aad7b
Showing 1 changed file with 6 additions and 11 deletions.
17 changes: 6 additions & 11 deletions drivers/net/sfc/efx.c
Original file line number Diff line number Diff line change
Expand Up @@ -1774,7 +1774,7 @@ static struct pci_device_id efx_pci_table[] __devinitdata = {
*
* Dummy PHY/MAC/Board operations
*
* Can be used where the MAC does not implement this operation
* Can be used for some unimplemented operations
* Needed so all function pointers are valid and do not have to be tested
* before use
*
Expand All @@ -1795,17 +1795,12 @@ static struct efx_phy_operations efx_dummy_phy_operations = {
.reset_xaui = efx_port_dummy_op_void,
};

/* Dummy board operations */
static int efx_nic_dummy_op_int(struct efx_nic *nic)
{
return 0;
}

static struct efx_board efx_dummy_board_info = {
.init = efx_nic_dummy_op_int,
.init_leds = efx_port_dummy_op_int,
.set_fault_led = efx_port_dummy_op_blink,
.fini = efx_port_dummy_op_void,
.init = efx_port_dummy_op_int,
.init_leds = efx_port_dummy_op_int,
.set_fault_led = efx_port_dummy_op_blink,
.blink = efx_port_dummy_op_blink,
.fini = efx_port_dummy_op_void,
};

/**************************************************************************
Expand Down

0 comments on commit 01aad7b

Please sign in to comment.