Skip to content

Commit

Permalink
svcrpc: no need for XPT_DEAD check in svc_xprt_enqueue
Browse files Browse the repository at this point in the history
If any xprt marked DEAD is also left BUSY for the rest of its life, then
the XPT_DEAD check here is superfluous--we'll get the same result from
the XPT_BUSY check just after.

Signed-off-by: J. Bruce Fields <bfields@redhat.com>
  • Loading branch information
J. Bruce Fields committed Oct 25, 2010
1 parent ac9303e commit 01dba07
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions net/sunrpc/svc_xprt.c
Original file line number Diff line number Diff line change
Expand Up @@ -330,12 +330,6 @@ void svc_xprt_enqueue(struct svc_xprt *xprt)
"svc_xprt_enqueue: "
"threads and transports both waiting??\n");

if (test_bit(XPT_DEAD, &xprt->xpt_flags)) {
/* Don't enqueue dead transports */
dprintk("svc: transport %p is dead, not enqueued\n", xprt);
goto out_unlock;
}

pool->sp_stats.packets++;

/* Mark transport as busy. It will remain in this state until
Expand Down

0 comments on commit 01dba07

Please sign in to comment.