Skip to content

Commit

Permalink
GFS2: make sure S_NOSEC flag isn't overwritten
Browse files Browse the repository at this point in the history
At the end of gfs2_set_inode_flags inode->i_flags is set to flags, so
we should be modifying flags instead of inode->i_flags, so it isn't
overwritten.

Signed-off-by: Benjamin Marzinski <bmarzins redhat com>
Signed-off-by: Bob Peterson <rpeterso@redhat.com>
  • Loading branch information
Benjamin Marzinski authored and Bob Peterson committed May 5, 2015
1 parent a63b7bb commit 01e64ee
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fs/gfs2/file.c
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ void gfs2_set_inode_flags(struct inode *inode)

flags &= ~(S_SYNC|S_APPEND|S_IMMUTABLE|S_NOATIME|S_DIRSYNC|S_NOSEC);
if ((ip->i_eattr == 0) && !is_sxid(inode->i_mode))
inode->i_flags |= S_NOSEC;
flags |= S_NOSEC;
if (ip->i_diskflags & GFS2_DIF_IMMUTABLE)
flags |= S_IMMUTABLE;
if (ip->i_diskflags & GFS2_DIF_APPENDONLY)
Expand Down

0 comments on commit 01e64ee

Please sign in to comment.