Skip to content

Commit

Permalink
caif: Kconfig and Makefile fixes
Browse files Browse the repository at this point in the history
Use "depends on" instead of "if" in Kconfig files.
Fixed CAIF debug flag, and removed unnecessary clean-* options.

Signed-off-by: Sjur Braendeland <sjur.brandeland@stericsson.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Sjur Braendeland authored and David S. Miller committed Jun 29, 2010
1 parent cfc9b16 commit 01eebb5
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 29 deletions.
5 changes: 1 addition & 4 deletions drivers/net/caif/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,13 @@
# CAIF physical drivers
#

if CAIF

comment "CAIF transport drivers"

config CAIF_TTY
tristate "CAIF TTY transport driver"
depends on CAIF
default n
---help---
The CAIF TTY transport driver is a Line Discipline (ldisc)
identified as N_CAIF. When this ldisc is opened from user space
it will redirect the TTY's traffic into the CAIF stack.

endif # CAIF
10 changes: 2 additions & 8 deletions drivers/net/caif/Makefile
Original file line number Diff line number Diff line change
@@ -1,12 +1,6 @@
ifeq ($(CONFIG_CAIF_DEBUG),1)
CAIF_DBG_FLAGS := -DDEBUG
ifeq ($(CONFIG_CAIF_DEBUG),y)
EXTRA_CFLAGS += -DDEBUG
endif

KBUILD_EXTRA_SYMBOLS=net/caif/Module.symvers

ccflags-y := $(CAIF_FLAGS) $(CAIF_DBG_FLAGS)
clean-dirs:= .tmp_versions
clean-files:= Module.symvers modules.order *.cmd *~ \

# Serial interface
obj-$(CONFIG_CAIF_TTY) += caif_serial.o
7 changes: 2 additions & 5 deletions net/caif/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -21,25 +21,22 @@ menuconfig CAIF
See Documentation/networking/caif for a further explanation on how to
use and configure CAIF.

if CAIF

config CAIF_DEBUG
bool "Enable Debug"
depends on CAIF
default n
--- help ---
Enable the inclusion of debug code in the CAIF stack.
Be aware that doing this will impact performance.
If unsure say N.


config CAIF_NETDEV
tristate "CAIF GPRS Network device"
depends on CAIF
default CAIF
---help---
Say Y if you will be using a CAIF based GPRS network device.
This can be either built-in or a loadable module,
If you select to build it as a built-in then the main CAIF device must
also be a built-in.
If unsure say Y.

endif
14 changes: 2 additions & 12 deletions net/caif/Makefile
Original file line number Diff line number Diff line change
@@ -1,23 +1,13 @@
ifeq ($(CONFIG_CAIF_DEBUG),1)
CAIF_DBG_FLAGS := -DDEBUG
ifeq ($(CONFIG_CAIF_DEBUG),y)
EXTRA_CFLAGS += -DDEBUG
endif

ccflags-y := $(CAIF_FLAGS) $(CAIF_DBG_FLAGS)

caif-objs := caif_dev.o \
cfcnfg.o cfmuxl.o cfctrl.o \
cffrml.o cfveil.o cfdbgl.o\
cfserl.o cfdgml.o \
cfrfml.o cfvidl.o cfutill.o \
cfsrvl.o cfpkt_skbuff.o caif_config_util.o
clean-dirs:= .tmp_versions

clean-files:= \
Module.symvers \
modules.order \
*.cmd \
*.o \
*~

obj-$(CONFIG_CAIF) += caif.o
obj-$(CONFIG_CAIF_NETDEV) += chnl_net.o
Expand Down

0 comments on commit 01eebb5

Please sign in to comment.