Skip to content

Commit

Permalink
PLIP driver: convert the semaphore killed_timer_sem to completion
Browse files Browse the repository at this point in the history
Signed-off-by: Matthias Kaehlcke <matthias.kaehlcke@gmail.com>
Cc: Jeff Garzik <jeff@garzik.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
  • Loading branch information
Matthias Kaehlcke authored and David S. Miller committed Jan 28, 2008
1 parent 07b270e commit 01f31ac
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions drivers/net/plip.c
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ static const char version[] = "NET3 PLIP version 2.4-parport gniibe@mri.co.jp\n"
#include <linux/if_plip.h>
#include <linux/workqueue.h>
#include <linux/spinlock.h>
#include <linux/completion.h>
#include <linux/parport.h>
#include <linux/bitops.h>

Expand All @@ -114,7 +115,6 @@ static const char version[] = "NET3 PLIP version 2.4-parport gniibe@mri.co.jp\n"
#include <asm/system.h>
#include <asm/irq.h>
#include <asm/byteorder.h>
#include <asm/semaphore.h>

/* Maximum number of devices to support. */
#define PLIP_MAX 8
Expand Down Expand Up @@ -221,7 +221,7 @@ struct net_local {
int should_relinquish;
spinlock_t lock;
atomic_t kill_timer;
struct semaphore killed_timer_sem;
struct completion killed_timer_cmp;
};

static inline void enable_parport_interrupts (struct net_device *dev)
Expand Down Expand Up @@ -385,7 +385,7 @@ plip_timer_bh(struct work_struct *work)
schedule_delayed_work(&nl->timer, 1);
}
else {
up (&nl->killed_timer_sem);
complete(&nl->killed_timer_cmp);
}
}

Expand Down Expand Up @@ -1112,9 +1112,9 @@ plip_close(struct net_device *dev)

if (dev->irq == -1)
{
init_MUTEX_LOCKED (&nl->killed_timer_sem);
init_completion(&nl->killed_timer_cmp);
atomic_set (&nl->kill_timer, 1);
down (&nl->killed_timer_sem);
wait_for_completion(&nl->killed_timer_cmp);
}

#ifdef NOTDEF
Expand Down

0 comments on commit 01f31ac

Please sign in to comment.