Skip to content

Commit

Permalink
batman-adv: Do not add multicast MAC addresses to translation table
Browse files Browse the repository at this point in the history
The current translation table mechanism is not suitable for multicast
addresses and we are currently flooding such frames anyway.

Therefore this patch prevents multicast MAC addresses being added to the
translation table.

Signed-off-by: Linus Lüssing <linus.luessing@web.de>
Acked-by: Antonio Quartulli <ordex@autistici.org>
Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
Signed-off-by: Antonio Quartulli <ordex@autistici.org>
  • Loading branch information
Linus Lüssing authored and Antonio Quartulli committed Jan 12, 2013
1 parent 5691744 commit 02233e0
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion net/batman-adv/soft-interface.c
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,8 @@ static int batadv_interface_tx(struct sk_buff *skb,
goto dropped;

/* Register the client MAC in the transtable */
batadv_tt_local_add(soft_iface, ethhdr->h_source, skb->skb_iif);
if (!is_multicast_ether_addr(ethhdr->h_source))
batadv_tt_local_add(soft_iface, ethhdr->h_source, skb->skb_iif);

/* don't accept stp packets. STP does not help in meshes.
* better use the bridge loop avoidance ...
Expand Down

0 comments on commit 02233e0

Please sign in to comment.