Skip to content

Commit

Permalink
[media] soc_camera: Use devm_kzalloc function
Browse files Browse the repository at this point in the history
devm_kzalloc() has been used to simplify error handling.
While at it, the soc_camera_device_register function has been moved to
save a few lines of code and a variable.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
[g.liakhovetski@gmx.de: remove a superfluous empty line]
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Sachin Kamat authored and Mauro Carvalho Chehab committed Oct 6, 2012
1 parent ec0341b commit 0224936
Showing 1 changed file with 2 additions and 14 deletions.
16 changes: 2 additions & 14 deletions drivers/media/platform/soc_camera/soc_camera.c
Original file line number Diff line number Diff line change
Expand Up @@ -1529,12 +1529,11 @@ static int __devinit soc_camera_pdrv_probe(struct platform_device *pdev)
{
struct soc_camera_link *icl = pdev->dev.platform_data;
struct soc_camera_device *icd;
int ret;

if (!icl)
return -EINVAL;

icd = kzalloc(sizeof(*icd), GFP_KERNEL);
icd = devm_kzalloc(&pdev->dev, sizeof(*icd), GFP_KERNEL);
if (!icd)
return -ENOMEM;

Expand All @@ -1543,19 +1542,10 @@ static int __devinit soc_camera_pdrv_probe(struct platform_device *pdev)
icd->pdev = &pdev->dev;
platform_set_drvdata(pdev, icd);

ret = soc_camera_device_register(icd);
if (ret < 0)
goto escdevreg;

icd->user_width = DEFAULT_WIDTH;
icd->user_height = DEFAULT_HEIGHT;

return 0;

escdevreg:
kfree(icd);

return ret;
return soc_camera_device_register(icd);
}

/*
Expand All @@ -1572,8 +1562,6 @@ static int __devexit soc_camera_pdrv_remove(struct platform_device *pdev)

list_del(&icd->list);

kfree(icd);

return 0;
}

Expand Down

0 comments on commit 0224936

Please sign in to comment.