Skip to content

Commit

Permalink
mac80211: return correct error return from ieee80211_wep_init
Browse files Browse the repository at this point in the history
Return the proper error code rather than a hard-coded ENOMEM from
ieee80211_wep_init.  Also, print the error code on failure.

Signed-off-by: Jeremy Fitzhardinge <jeremy@goop.org>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
  • Loading branch information
Jeremy Fitzhardinge authored and John W. Linville committed Jul 29, 2008
1 parent 1b02416 commit 023a04b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions net/mac80211/main.c
Original file line number Diff line number Diff line change
Expand Up @@ -1731,8 +1731,8 @@ int ieee80211_register_hw(struct ieee80211_hw *hw)
result = ieee80211_wep_init(local);

if (result < 0) {
printk(KERN_DEBUG "%s: Failed to initialize wep\n",
wiphy_name(local->hw.wiphy));
printk(KERN_DEBUG "%s: Failed to initialize wep: %d\n",
wiphy_name(local->hw.wiphy), result);
goto fail_wep;
}

Expand Down
4 changes: 2 additions & 2 deletions net/mac80211/wep.c
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,13 @@ int ieee80211_wep_init(struct ieee80211_local *local)
local->wep_tx_tfm = crypto_alloc_blkcipher("ecb(arc4)", 0,
CRYPTO_ALG_ASYNC);
if (IS_ERR(local->wep_tx_tfm))
return -ENOMEM;
return PTR_ERR(local->wep_tx_tfm);

local->wep_rx_tfm = crypto_alloc_blkcipher("ecb(arc4)", 0,
CRYPTO_ALG_ASYNC);
if (IS_ERR(local->wep_rx_tfm)) {
crypto_free_blkcipher(local->wep_tx_tfm);
return -ENOMEM;
return PTR_ERR(local->wep_rx_tfm);
}

return 0;
Expand Down

0 comments on commit 023a04b

Please sign in to comment.