Skip to content

Commit

Permalink
[PATCH] ioremap balanced with iounmap for drivers/video/retz3fb
Browse files Browse the repository at this point in the history
ioremap must be balanced by an iounmap and failing to do so can result in a
memory leak.

Signed-off-by: Amol Lad <amol@verismonetworks.com>
Cc: "Antonino A. Daplas" <adaplas@pol.net>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Amol Lad authored and Linus Torvalds committed Dec 8, 2006
1 parent 9cf2014 commit 027b53d
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion drivers/video/retz3fb.c
Original file line number Diff line number Diff line change
Expand Up @@ -1423,8 +1423,10 @@ int __init retz3fb_init(void)

do_install_cmap(0, fb_info);

if (register_framebuffer(fb_info) < 0)
if (register_framebuffer(fb_info) < 0) {
iounmap(zinfo->base);
return -EINVAL;
}

printk(KERN_INFO "fb%d: %s frame buffer device, using %ldK of "
"video memory\n", fb_info->node,
Expand Down

0 comments on commit 027b53d

Please sign in to comment.