Skip to content

Commit

Permalink
bridge: cleanup: remove unneed check
Browse files Browse the repository at this point in the history
We dereference "port" on the lines immediately before and immediately
after the test so port should hopefully never be null here.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Dan Carpenter authored and David S. Miller committed Mar 7, 2010
1 parent b96b894 commit 02a780c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions net/bridge/br_multicast.c
Original file line number Diff line number Diff line change
Expand Up @@ -627,8 +627,8 @@ static void br_multicast_port_query_expired(unsigned long data)
struct net_bridge *br = port->br;

spin_lock(&br->multicast_lock);
if (port && (port->state == BR_STATE_DISABLED ||
port->state == BR_STATE_BLOCKING))
if (port->state == BR_STATE_DISABLED ||
port->state == BR_STATE_BLOCKING)
goto out;

if (port->multicast_startup_queries_sent <
Expand Down

0 comments on commit 02a780c

Please sign in to comment.