Skip to content

Commit

Permalink
USB: Option driver: Short driver names were identical
Browse files Browse the repository at this point in the history
The short driver names were not unique,
which prevented the driver from actually loading.

Also, one of the ioctl pointers was missing.

Signed-Off-By: Matthias Urlichs <smurf@smurf.noris.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Matthias Urlichs authored and Greg Kroah-Hartman committed Aug 2, 2006
1 parent b3fdab5 commit 02b2ac5
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions drivers/usb/serial/option.c
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ static struct usb_driver option_driver = {
static struct usb_serial_driver option_3port_device = {
.driver = {
.owner = THIS_MODULE,
.name = "option",
.name = "option3",
},
.description = "GSM modem (3-port)",
.id_table = option_ids3,
Expand All @@ -143,6 +143,7 @@ static struct usb_serial_driver option_3port_device = {
.chars_in_buffer = option_chars_in_buffer,
.throttle = option_rx_throttle,
.unthrottle = option_rx_unthrottle,
.ioctl = option_ioctl,
.set_termios = option_set_termios,
.break_ctl = option_break_ctl,
.tiocmget = option_tiocmget,
Expand All @@ -155,7 +156,7 @@ static struct usb_serial_driver option_3port_device = {
static struct usb_serial_driver option_1port_device = {
.driver = {
.owner = THIS_MODULE,
.name = "option",
.name = "option1",
},
.description = "GSM modem (1-port)",
.id_table = option_ids1,
Expand Down Expand Up @@ -630,7 +631,6 @@ static void option_setup_urbs(struct usb_serial *serial)

dbg("%s", __FUNCTION__);


for (i = 0; i < serial->num_ports; i++) {
port = serial->port[i];
portdata = usb_get_serial_port_data(port);
Expand Down

0 comments on commit 02b2ac5

Please sign in to comment.