Skip to content

Commit

Permalink
infiniband: Convert dst_fetch_ha() over to dst_neigh_lookup().
Browse files Browse the repository at this point in the history
Now we must provide the IP destination address, and a reference has
to be dropped when we're done with the entry.

Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
David Miller committed Jan 26, 2012
1 parent 9b28ecd commit 02b6195
Showing 1 changed file with 9 additions and 5 deletions.
14 changes: 9 additions & 5 deletions drivers/infiniband/core/addr.c
Original file line number Diff line number Diff line change
Expand Up @@ -178,22 +178,26 @@ static void queue_req(struct addr_req *req)
mutex_unlock(&lock);
}

static int dst_fetch_ha(struct dst_entry *dst, struct rdma_dev_addr *addr)
static int dst_fetch_ha(struct dst_entry *dst, struct rdma_dev_addr *dev_addr, void *daddr)
{
struct neighbour *n;
int ret;

n = dst_neigh_lookup(dst, daddr);

rcu_read_lock();
n = dst_get_neighbour_noref(dst);
if (!n || !(n->nud_state & NUD_VALID)) {
if (n)
neigh_event_send(n, NULL);
ret = -ENODATA;
} else {
ret = rdma_copy_addr(addr, dst->dev, n->ha);
ret = rdma_copy_addr(dev_addr, dst->dev, n->ha);
}
rcu_read_unlock();

if (n)
neigh_release(n);

return ret;
}

Expand Down Expand Up @@ -232,7 +236,7 @@ static int addr4_resolve(struct sockaddr_in *src_in,
goto put;
}

ret = dst_fetch_ha(&rt->dst, addr);
ret = dst_fetch_ha(&rt->dst, addr, &fl4.daddr);
put:
ip_rt_put(rt);
out:
Expand Down Expand Up @@ -280,7 +284,7 @@ static int addr6_resolve(struct sockaddr_in6 *src_in,
goto put;
}

ret = dst_fetch_ha(dst, addr);
ret = dst_fetch_ha(dst, addr, &fl6.daddr);
put:
dst_release(dst);
return ret;
Expand Down

0 comments on commit 02b6195

Please sign in to comment.