Skip to content

Commit

Permalink
ocfs2: Use buckets in ocfs2_xattr_set_entry_in_bucket().
Browse files Browse the repository at this point in the history
The ocfs2_xattr_set_entry_in_bucket() function is already working on an
ocfs2_xattr_bucket structure, so let's use the bucket API.

Signed-off-by: Joel Becker <joel.becker@oracle.com>
Signed-off-by: Mark Fasheh <mfasheh@suse.com>
  • Loading branch information
Joel Becker authored and Mark Fasheh committed Jan 5, 2009
1 parent 161d6f3 commit 02dbf38
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions fs/ocfs2/xattr.c
Original file line number Diff line number Diff line change
Expand Up @@ -4083,25 +4083,24 @@ static int ocfs2_xattr_set_entry_in_bucket(struct inode *inode,
{
int ret;
handle_t *handle = NULL;
u16 blk_per_bucket = ocfs2_blocks_per_xattr_bucket(inode->i_sb);
struct ocfs2_super *osb = OCFS2_SB(inode->i_sb);
u64 blkno;

mlog(0, "Set xattr entry len = %lu index = %d in bucket %llu\n",
(unsigned long)xi->value_len, xi->name_index,
(unsigned long long)bucket_blkno(xs->bucket));

if (!xs->bucket->bu_bhs[1]) {
ret = ocfs2_read_blocks(inode,
bucket_blkno(xs->bucket) + 1,
blk_per_bucket - 1, &xs->bucket->bu_bhs[1],
0);
blkno = bucket_blkno(xs->bucket);
ocfs2_xattr_bucket_relse(xs->bucket);
ret = ocfs2_read_xattr_bucket(xs->bucket, blkno);
if (ret) {
mlog_errno(ret);
goto out;
}
}

handle = ocfs2_start_trans(osb, blk_per_bucket);
handle = ocfs2_start_trans(osb, xs->bucket->bu_blocks);
if (IS_ERR(handle)) {
ret = PTR_ERR(handle);
handle = NULL;
Expand Down

0 comments on commit 02dbf38

Please sign in to comment.