Skip to content

Commit

Permalink
[ACPI] acpi_remove_notify_handler() on video driver unload
Browse files Browse the repository at this point in the history
The video driver doesn't properly remove all the notify handlers
on module unload.  This has a side effect of subdevices failing
to register on module reload, but sudden death looms if the
handlers trigger after the module is unloaded.

Signed-off-by: Karol Kozimor <sziwan@hell.org.pl>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Len Brown <len.brown@intel.com>
  • Loading branch information
Karol Kozimor authored and Len Brown committed Aug 5, 2005
1 parent e92310a commit 031ec77
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions drivers/acpi/video.c
Original file line number Diff line number Diff line change
Expand Up @@ -1665,6 +1665,7 @@ static int
acpi_video_bus_put_one_device(
struct acpi_video_device *device)
{
acpi_status status;
struct acpi_video_bus *video;

ACPI_FUNCTION_TRACE("acpi_video_bus_put_one_device");
Expand All @@ -1679,6 +1680,12 @@ acpi_video_bus_put_one_device(
up(&video->sem);
acpi_video_device_remove_fs(device->dev);

status = acpi_remove_notify_handler(device->handle,
ACPI_DEVICE_NOTIFY, acpi_video_device_notify);
if (ACPI_FAILURE(status))
ACPI_DEBUG_PRINT((ACPI_DB_ERROR,
"Error removing notify handler\n"));

return_VALUE(0);
}

Expand Down

0 comments on commit 031ec77

Please sign in to comment.