Skip to content

Commit

Permalink
x86_64: simplify the memtest parameter setting
Browse files Browse the repository at this point in the history
use CONFIG_MEMTEST only. if it is set, will have memtest=0 (disabled)

need to have memtest=4 in command line to test more patterns.

Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
  • Loading branch information
Yinghai Lu authored and Ingo Molnar committed May 12, 2008
1 parent 492c2e4 commit 0327318
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 25 deletions.
30 changes: 7 additions & 23 deletions arch/x86/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -419,35 +419,19 @@ config PARAVIRT

endif

config MEMTEST_BOOTPARAM
bool "Memtest boot parameter"
config MEMTEST
bool "Memtest"
depends on X86_64
default y
help
This option adds a kernel parameter 'memtest', which allows memtest
to be disabled at boot. If this option is selected, memtest
functionality can be disabled with memtest=0 on the kernel
command line. The purpose of this option is to allow a single
kernel image to be distributed with memtest built in, but not
necessarily enabled.

to be set.
memtest=0, mean disabled; -- default
memtest=1, mean do 1 test pattern;
...
memtest=4, mean do 4 test patterns.
If you are unsure how to answer this question, answer Y.

config MEMTEST_BOOTPARAM_VALUE
int "Memtest boot parameter default value (0-4)"
depends on MEMTEST_BOOTPARAM
range 0 4
default 0
help
This option sets the default value for the kernel parameter
'memtest', which allows memtest to be disabled at boot. If this
option is set to 0 (zero), the memtest kernel parameter will
default to 0, disabling memtest at bootup. If this option is
set to 4, the memtest kernel parameter will default to 4,
enabling memtest at bootup, and use that as pattern number.

If you are unsure how to answer this question, answer 0.

config ACPI_SRAT
def_bool y
depends on X86_32 && ACPI && NUMA && (X86_SUMMIT || X86_GENERICARCH)
Expand Down
5 changes: 3 additions & 2 deletions arch/x86/mm/init_64.c
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,7 @@ static void __init init_gbpages(void)
direct_gbpages = 0;
}

#ifdef CONFIG_MEMTEST_BOOTPARAM
#ifdef CONFIG_MEMTEST

static void __init memtest(unsigned long start_phys, unsigned long size,
unsigned pattern)
Expand Down Expand Up @@ -493,7 +493,8 @@ static void __init memtest(unsigned long start_phys, unsigned long size,

}

static int memtest_pattern __initdata = CONFIG_MEMTEST_BOOTPARAM_VALUE;
/* default is disabled */
static int memtest_pattern __initdata;

static int __init parse_memtest(char *arg)
{
Expand Down

0 comments on commit 0327318

Please sign in to comment.