Skip to content

Commit

Permalink
OMAP3: PM: CPUidle: fix init sequencing
Browse files Browse the repository at this point in the history
Previously omap3_idle_init() was called in device_init, while
omap_pm_init() is called at late_initcall. This causes the cpu idle
driver to call omap_sram_idle before it is properly initialized. This
patch fixes the issue by moving omap3_idle_init into omap3_pm_init.

Signed-off-by: Kalle Jokiniemi <ext-kalle.jokiniemi@nokia.com>
Signed-off-by: Kevin Hilman <khilman@deeprootsystems.com>
  • Loading branch information
Kalle Jokiniemi authored and Kevin Hilman committed Nov 11, 2009
1 parent 0f724ed commit 0343371
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 4 deletions.
8 changes: 6 additions & 2 deletions arch/arm/mach-omap2/cpuidle34xx.c
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ struct cpuidle_driver omap3_idle_driver = {
* Registers the OMAP3 specific cpuidle driver with the cpuidle
* framework with the valid set of states.
*/
int omap3_idle_init(void)
int __init omap3_idle_init(void)
{
int i, count = 0;
struct omap3_processor_cx *cx;
Expand Down Expand Up @@ -272,5 +272,9 @@ int omap3_idle_init(void)

return 0;
}
device_initcall(omap3_idle_init);
#else
int __init omap3_idle_init(void)
{
return 0;
}
#endif /* CONFIG_CPU_IDLE */
1 change: 1 addition & 0 deletions arch/arm/mach-omap2/pm.h
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ extern void omap3_pm_off_mode_enable(int);
extern void omap_sram_idle(void);
extern int omap3_can_sleep(void);
extern int set_pwrdm_state(struct powerdomain *pwrdm, u32 state);
extern int omap3_idle_init(void);

extern int omap3_pm_get_suspend_state(struct powerdomain *pwrdm);
extern int omap3_pm_set_suspend_state(struct powerdomain *pwrdm, int state);
Expand Down
3 changes: 1 addition & 2 deletions arch/arm/mach-omap2/pm34xx.c
Original file line number Diff line number Diff line change
Expand Up @@ -1099,9 +1099,8 @@ static int __init omap3_pm_init(void)
suspend_set_ops(&omap_pm_ops);
#endif /* CONFIG_SUSPEND */

#ifndef CONFIG_CPU_IDLE
pm_idle = omap3_pm_idle;
#endif
omap3_idle_init();

pwrdm_add_wkdep(neon_pwrdm, mpu_pwrdm);
/*
Expand Down

0 comments on commit 0343371

Please sign in to comment.