Skip to content

Commit

Permalink
openvswitch: Avoid useless holes in struct vport
Browse files Browse the repository at this point in the history
Having the 16bit port_no in between a set of pointers creates
an unwanted and useless hole in the struct.

Signed-off-by: Thomas Graf <tgraf@suug.ch>
Signed-off-by: Jesse Gross <jesse@nicira.com>
  • Loading branch information
Thomas Graf authored and Jesse Gross committed Dec 4, 2012
1 parent 9151991 commit 03599c9
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions net/openvswitch/vport.h
Original file line number Diff line number Diff line change
Expand Up @@ -68,10 +68,10 @@ struct vport_err_stats {
/**
* struct vport - one port within a datapath
* @rcu: RCU callback head for deferred destruction.
* @port_no: Index into @dp's @ports array.
* @dp: Datapath to which this port belongs.
* @upcall_portid: The Netlink port to use for packets received on this port that
* miss the flow table.
* @port_no: Index into @dp's @ports array.
* @hash_node: Element in @dev_table hash table in vport.c.
* @dp_hash_node: Element in @datapath->ports hash table in datapath.c.
* @ops: Class structure.
Expand All @@ -81,9 +81,9 @@ struct vport_err_stats {
*/
struct vport {
struct rcu_head rcu;
u16 port_no;
struct datapath *dp;
u32 upcall_portid;
u16 port_no;

struct hlist_node hash_node;
struct hlist_node dp_hash_node;
Expand Down

0 comments on commit 03599c9

Please sign in to comment.