Skip to content

Commit

Permalink
of/sparc: move is_root_node() to of.h
Browse files Browse the repository at this point in the history
Rename is_root_node() to of_node_is_root() and make it available for
all archs to use, as it's not PROM-specific.

Signed-off-by: Andres Salomon <dilinger@queued.net>
Acked-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
  • Loading branch information
Andres Salomon authored and Grant Likely committed Jul 14, 2010
1 parent ef2a452 commit 035ebef
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 12 deletions.
8 changes: 0 additions & 8 deletions arch/sparc/kernel/prom.h
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,6 @@ extern void irq_trans_init(struct device_node *dp);

extern unsigned int prom_unique_id;

static inline int is_root_node(const struct device_node *dp)
{
if (!dp)
return 0;

return (dp->parent == NULL);
}

extern char *build_path_component(struct device_node *dp);
extern void of_console_init(void);

Expand Down
6 changes: 3 additions & 3 deletions arch/sparc/kernel/prom_64.c
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
#include <linux/mm.h>
#include <linux/module.h>
#include <linux/lmb.h>
#include <linux/of_device.h>
#include <linux/of.h>

#include <asm/prom.h>
#include <asm/oplib.h>
Expand Down Expand Up @@ -81,7 +81,7 @@ static void __init sun4v_path_component(struct device_node *dp, char *tmp_buf)
return;

regs = rprop->value;
if (!is_root_node(dp->parent)) {
if (!of_node_is_root(dp->parent)) {
sprintf(tmp_buf, "%s@%x,%x",
dp->name,
(unsigned int) (regs->phys_addr >> 32UL),
Expand Down Expand Up @@ -121,7 +121,7 @@ static void __init sun4u_path_component(struct device_node *dp, char *tmp_buf)
return;

regs = prop->value;
if (!is_root_node(dp->parent)) {
if (!of_node_is_root(dp->parent)) {
sprintf(tmp_buf, "%s@%x,%x",
dp->name,
(unsigned int) (regs->phys_addr >> 32UL),
Expand Down
2 changes: 1 addition & 1 deletion arch/sparc/kernel/prom_common.c
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ char * __init build_full_name(struct device_node *dp)

n = prom_early_alloc(len);
strcpy(n, dp->parent->full_name);
if (!is_root_node(dp->parent)) {
if (!of_node_is_root(dp->parent)) {
strcpy(n + plen, "/");
plen++;
}
Expand Down
5 changes: 5 additions & 0 deletions include/linux/of.h
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,11 @@ extern struct device_node *allnodes;
extern struct device_node *of_chosen;
extern rwlock_t devtree_lock;

static inline bool of_node_is_root(const struct device_node *node)
{
return node && (node->parent == NULL);
}

static inline int of_node_check_flag(struct device_node *n, unsigned long flag)
{
return test_bit(flag, &n->_flags);
Expand Down

0 comments on commit 035ebef

Please sign in to comment.