Skip to content

Commit

Permalink
Bluetooth: Simplify the ERTM ack timeout
Browse files Browse the repository at this point in the history
Since l2cap_send_ack can trigger extra actions like sending iframes,
don't call it.  Just send an RR or RNR frame if an ack needs sending.

Signed-off-by: Mat Martineau <mathewm@codeaurora.org>
Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
  • Loading branch information
Mat Martineau authored and Johan Hedberg committed Jun 5, 2012
1 parent 80909e0 commit 0362520
Showing 1 changed file with 7 additions and 3 deletions.
10 changes: 7 additions & 3 deletions net/bluetooth/l2cap_core.c
Original file line number Diff line number Diff line change
Expand Up @@ -2761,16 +2761,20 @@ static void l2cap_add_opt_efs(void **ptr, struct l2cap_chan *chan)
static void l2cap_ack_timeout(struct work_struct *work)
{
struct l2cap_chan *chan = container_of(work, struct l2cap_chan,
ack_timer.work);
ack_timer.work);
u16 frames_to_ack;

BT_DBG("chan %p", chan);

l2cap_chan_lock(chan);

l2cap_send_ack(chan);
frames_to_ack = __seq_offset(chan, chan->buffer_seq,
chan->last_acked_seq);

l2cap_chan_unlock(chan);
if (frames_to_ack)
l2cap_send_rr_or_rnr(chan, 0);

l2cap_chan_unlock(chan);
l2cap_chan_put(chan);
}

Expand Down

0 comments on commit 0362520

Please sign in to comment.